Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Assistant] Reorganize folder structure #94843

Merged
merged 11 commits into from
Mar 24, 2021
Merged

[Upgrade Assistant] Reorganize folder structure #94843

merged 11 commits into from
Mar 24, 2021

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Mar 17, 2021 •
edited
Loading

This PR reorganizes the public folder structure in preparation for supporting Kibana deprecations. The main change is flattening the components directory by removing the tabs directory, and renaming the checkup directory to elasticsearch.

Current folder structure:

public
  - components
    - tabs
      - checkup
      - overview
  - utils.ts
  - utils.test.ts
  - app.tsx
  - app_context.tsx
  - ...

New folder structure:

public
  - components
    - overview
    - es_deprecations // the `checkup_tab.tsx` component was also renamed to `deprecation_tab.tsx` in this directory. This will likely go through more iterations as we are moving away from tabs in the redesign.
    - [Future] kibana_deprecations // components to render kibana deprecations
    - [Future] shared // there will likely be some shared components (e.g., to display the list of deprecations) between ES and Kibana
  - lib
    - utils.ts
    - utils.test.ts
  - app.tsx
  - app_context.tsx
  - ...same as before

How to review

Most of the changes in this PR are all related to updating import paths and renaming files. The main thing to review is the new folder structure outlined above and verify it makes sense moving forward.

@alisonelizabeth alisonelizabeth added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.13.0 labels Mar 17, 2021
@alisonelizabeth alisonelizabeth marked this pull request as ready for review March 18, 2021 17:25
@alisonelizabeth alisonelizabeth requested review from a team as code owners March 18, 2021 17:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

mdefazio
mdefazio approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me too!

I was just thinking, qualifying directory names beyond elasticsearch and kibana (to something like elasticsearch_deprecations or elasticsarch_issues) would mentally narrow down what I might expect to find these folders. Just a thought, other than looks great!

@alisonelizabeth
Copy link
Contributor Author

I was just thinking, qualifying directory names beyond elasticsearch and kibana (to something like elasticsearch_deprecations or elasticsarch_issues) would mentally narrow down what I might expect to find these folders.

That's a great point! I've renamed the ES folder to es_deprecations and I will plan to do the same for kibana once we add support for it.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
upgradeAssistant 128 129 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 133.5KB 133.5KB +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit d0c0946 into elastic:master Mar 24, 2021
@alisonelizabeth alisonelizabeth deleted the ua/reorganize_folder_structure branch March 24, 2021 16:39
@alisonelizabeth alisonelizabeth mentioned this pull request Mar 24, 2021
Merged
alisonelizabeth added a commit that referenced this pull request Mar 24, 2021
@alisonelizabeth
[Upgrade Assistant] Reorganize folder structure (#94843) (#95336)
3169114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@mdefazio mdefazio mdefazio approved these changes

Assignees
No one assigned
Labels
chore Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisonelizabeth @elasticmachine @kibanamachine @mdefazio @jloleysens